Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear messed up feature flag on AppExitStates impl #13737

Merged
merged 1 commit into from
Jun 9, 2024
Merged

Clear messed up feature flag on AppExitStates impl #13737

merged 1 commit into from
Jun 9, 2024

Conversation

bugsweeper
Copy link
Contributor

@bugsweeper bugsweeper commented Jun 7, 2024 •
edited
Loading

Objective

Solution

  • Removed the feature gate.

Testing

@alice-i-cecile alice-i-cecile added this to the 0.14 milestone Jun 7, 2024
@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-ECS Entities, components, systems, and events P-Compile-Failure A failure to compile Bevy apps S-Needs-Review Needs reviewer attention (from anyone!) to move forward S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Jun 7, 2024
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jun 9, 2024
@mockersf mockersf added this pull request to the merge queue Jun 9, 2024
Merged via the queue into bevyengine:main with commit e9a3a0d Jun 9, 2024
35 checks passed
mockersf pushed a commit that referenced this pull request Jun 9, 2024
@bugsweeper @mockersf
Clear messed up feature flag on AppExitStates impl (#13737)
b14684e 
# Objective

- In #13649 additional method had been added to AppExitStates, but there
feature gate left for method in implementation for App at refactoring
stage.
- Fixes #13733 .

## Solution

- Removed the feature gate.

## Testing

- Ran reproducing example from #13733 with no compilation errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior P-Compile-Failure A failure to compile Bevy apps S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.14
Development

Successfully merging this pull request may close these issues.

bevy_state doesn't compile when only the bevy_app feature is enabled
3 participants
@bugsweeper @alice-i-cecile @mockersf