Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add insert_after and insert_startup_before #13941

Merged
merged 1 commit into from
Jun 20, 2024
Merged

feat: add insert_after and insert_startup_before #13941

merged 1 commit into from
Jun 20, 2024

Conversation

kettei-sproutty
Copy link
Contributor

Objective

Fixes #13866

Solution

Add insert_before in FixedMainScheduleOrder and MainScheduleOrder, add insert_startup_before in MainScheduleOrder, applying the same logic as insert_after, except for parameters naming and insertion index.

@ItsDoot ItsDoot added C-Feature A new feature, making something new possible A-App Bevy apps and plugins D-Straightforward Simple bug fixes and API improvements, docs, test and examples labels Jun 20, 2024
@ItsDoot ItsDoot added the X-Uncontroversial This work is generally agreed upon label Jun 20, 2024
alice-i-cecile
alice-i-cecile approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Much appreciated :)

@alice-i-cecile alice-i-cecile added C-Usability A targeted quality-of-life change that makes Bevy easier to use and removed C-Feature A new feature, making something new possible labels Jun 20, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 20, 2024
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jun 20, 2024
Merged via the queue into bevyengine:main with commit 2f9c42b Jun 20, 2024
34 checks passed
@mockersf mockersf added this to the 0.14.1 milestone Aug 2, 2024
mockersf pushed a commit that referenced this pull request Aug 2, 2024
@kettei-sproutty @mockersf
feat: add insert_after and insert_startup_before (#13941)
61c683f 
# Objective

Fixes #13866 

## Solution

Add `insert_before` in **FixedMainScheduleOrder** and
**MainScheduleOrder**, add `insert_startup_before` in
**MainScheduleOrder**, applying the same logic as `insert_after`, except
for parameters naming and insertion index.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@ItsDoot ItsDoot ItsDoot approved these changes

Assignees
No one assigned
Labels
A-App Bevy apps and plugins C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Uncontroversial This work is generally agreed upon
Projects
None yet
Milestone
0.14.1
Development

Successfully merging this pull request may close these issues.

Add MainScheduleOrder::insert_before()
4 participants
@kettei-sproutty @alice-i-cecile @ItsDoot @mockersf