Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label to transform propagation system #1438

Closed
wants to merge 6 commits into from
Closed

Add label to transform propagation system #1438

wants to merge 6 commits into from

Conversation

aevyrie
Copy link
Member

@aevyrie aevyrie commented Feb 12, 2021

Adds a label to the GlobalTransform transform propagation system. This is needed due to recent changes in the scheduler. I've been experiencing issues with systems running prior to GlobalTransforms being updated. A label is needed on the propagation system to allow me to specify a system dependency.

@TheRawMeatball
Copy link
Member

Hmm, there is a lot of other labels that need to be added as we resolve all internal ambiguities, so it might not be a good idea to add these labels one-by-one.

@aevyrie
Copy link
Member Author

aevyrie commented Feb 12, 2021

Hmm, there is a lot of other labels that need to be added as we resolve all internal ambiguities, so it might not be a good idea to add these labels one-by-one.

Right, but most of these are for internal disambiguation, correct? This is a label that really needs to be exposed publicly, so we can specify it as a system dep. The other reason I thought it was worth submitting as a lone label is because there might be larger discussion around this. Bugs caused by GlobalTransform system ordering are really common in my experience.

Edit: e.g. #1439

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen S-Duplicate This issue or PR already exists labels Feb 17, 2021
@alice-i-cecile
Copy link
Member

I think we should merge #1456 in preference to this due to it being a bit more complete.

@aevyrie
Copy link
Member Author

aevyrie commented Feb 17, 2021

I'll close this then. Thanks for the heads up @alice-i-cecile!

@aevyrie aevyrie closed this Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior S-Duplicate This issue or PR already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants