Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don’t prepare 2D view bind groups for 3D cameras #14481

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Don’t prepare 2D view bind groups for 3D cameras #14481

merged 1 commit into from
Jul 25, 2024

Conversation

brianreavis
Copy link
Contributor

Objective

  • Before this fix, the view query in prepare_mesh2d_view_bind_groups matched all views – leading to 2D view bind groups being prepared for 3D cameras.

Solution

  • Added With<Camera2d> to the views query.

Testing

  • Verified the examples still work.

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen C-Performance A change motivated by improving speed, memory usage or compile times S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Jul 25, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jul 25, 2024
Merged via the queue into bevyengine:main with commit 4382170 Jul 25, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@JMS55 JMS55 JMS55 approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior C-Performance A change motivated by improving speed, memory usage or compile times S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brianreavis @alice-i-cecile @JMS55