Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Add remove resource to commands #1478

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Add remove resource to commands #1478

wants to merge 1 commit into from

Conversation

NiklasEi
Copy link
Member

resolves #1468

alice-i-cecile
alice-i-cecile approved these changes Feb 19, 2021
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this is a nice little usability feature :)

@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Feb 19, 2021
Base automatically changed from master to main February 19, 2021 20:44
@cart
Copy link
Member

cart commented Feb 22, 2021

This looks good. I added remove_resource in my bevy ecs rewrite, but this seems pretty uncontroversial so im cool with merging it in the interim.

@cart
Copy link
Member

cart commented Feb 22, 2021

bors r+

bors bot pushed a commit that referenced this pull request Feb 22, 2021
@NiklasEi
Add remove resource to commands (#1478)
2e3af84 
resolves #1468 

Co-authored-by: Niklas Eicker <git@nikl.me>
@bors
Copy link
Contributor

bors bot commented Feb 22, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Add remove resource to commands [Merged by Bors] - Add remove resource to commands Feb 22, 2021
@bors bors bot closed this Feb 22, 2021
@NiklasEi NiklasEi deleted the add_remove_resource branch February 22, 2021 15:26
@alice-i-cecile alice-i-cecile mentioned this pull request Mar 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add method to remove resources via Commands
4 participants
@NiklasEi @cart @alice-i-cecile @mockersf