Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove bevy_utils::{default, prelude} #15343

Closed

Conversation

BenjaminBrienen
Copy link
Contributor

@BenjaminBrienen BenjaminBrienen commented Sep 20, 2024

Objective

Solution

  • Change references to bevy_utils::default to Default::default.
  • Remove use statements.
  • Remove empty prelude.

Testing

  • Local CI

Migration Guide

  • If using bevy_utils::default, stop. :)

@alice-i-cecile alice-i-cecile added X-Controversial There is active debate or serious implications around merging this PR A-Cross-Cutting Impacts the entire engine M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide labels Sep 20, 2024
@alice-i-cecile
Copy link
Member

@cart rather likes this style, and deliberately included it. IMO there's zero chance this is merged before the new bsn! macro drops, and little chance after it. I suspect that removing this will require a syntax improvement to Rust itself.

@BenjaminBrienen
Copy link
Contributor Author

@cart rather likes this style, and deliberately included it. IMO there's zero chance this is merged before the new bsn! macro drops, and little chance after it. I suspect that removing this will require a syntax improvement to Rust itself.

Would it not work to put Default::default in the bevy_internal prelude?

@alice-i-cecile
Copy link
Member

Would it not work to put Default::default in the bevy_internal prelude?

Hmm, this might work. I think that would be a lot more palatable, and still shrink bevy_utils.

@alice-i-cecile
Copy link
Member

Closing per #11478 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Cross-Cutting Impacts the entire engine M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide X-Controversial There is active debate or serious implications around merging this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants