Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Place percentage-closer soft shadows behind a feature gate to save on samplers. #16068

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Place percentage-closer soft shadows behind a feature gate to save on samplers. #16068

merged 2 commits into from
Oct 24, 2024

Commits on Oct 23, 2024

  1. Place percentage-closer soft shadows behind a feature gate to save on 

    samplers.

The two additional linear texture samplers that PCSS added caused us to
blow past the limit on Apple Silicon macOS and WebGL. To fix the issue,
this commit adds a `--feature pbr_pcss` feature gate that disables PCSS
if not present.

Closes bevyengine#15345.
Closes bevyengine#15525.
Closes bevyengine#15821.
    @pcwalton
    pcwalton committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    b5c0d57 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Update crates/bevy_internal/Cargo.toml 

    Co-authored-by: IceSentry <IceSentry@users.noreply.github.com>
    @cart @IceSentry
    cart and IceSentry authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    1ea1cd7 View commit details
    Browse the repository at this point in the history