[Merged by Bors] - More detailed errors when resource not found #1864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Code-Quality
I believe you can make the |
NiklasEi
reviewed
Apr 14, 2021
| @@ -242,7 +242,8 @@ impl<'a, T: Component> SystemParamFetch<'a> for ResState<T> { | |||
| .get_populated_resource_column(state.component_id) | |||
| .unwrap_or_else(|| { | |||
| panic!( | |||
| "Requested resource does not exist: {}", | |||
| "Resource requested by {} does not exist: {}", | |||
There was a problem hiding this comment.
What do you think of "Resource {} does not exist, but was requested by {}"?
There was a problem hiding this comment.
I think as written it flows a bit more naturally.
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 14, 2021
Fixes #1846 Got scared of the other "Requested resource does not exist" error at line 395 in `system_param.rs`, under `impl<'a, T: Component> SystemParamFetch<'a> for ResMutState<T> {`. Someone with better knowledge of the code might be able to go in and improve that one.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
|
@therealstork please respond in #2373 for the relicense to MIT/Apache 2.0. Thanks! |
ostwilkens
pushed a commit
to ostwilkens/bevy
that referenced
this pull request
Jul 27, 2021
Fixes bevyengine#1846 Got scared of the other "Requested resource does not exist" error at line 395 in `system_param.rs`, under `impl<'a, T: Component> SystemParamFetch<'a> for ResMutState<T> {`. Someone with better knowledge of the code might be able to go in and improve that one.
ostwilkens
pushed a commit
to ostwilkens/bevy
that referenced
this pull request
Jul 27, 2021
…evyengine#1986) Some panic messages for systems include the system name, but there's a few panic messages which do not. This PR adds the system name for the remaining panic messages. This is a continuation of the work done in bevyengine#1864. Related: bevyengine#1846
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1846
Got scared of the other "Requested resource does not exist" error at line 395 in
system_param.rs, underimpl<'a, T: Component> SystemParamFetch<'a> for ResMutState<T> {. Someone with better knowledge of the code might be able to go in and improve that one.