Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix IcoSphere UV coordinates #1871

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Fix IcoSphere UV coordinates #1871

wants to merge 1 commit into from

Conversation

OptimisticPeach
Copy link
Contributor

@OptimisticPeach OptimisticPeach commented Apr 10, 2021 •
edited
Loading

Changes made:

  • Swap Y/Z when calculating UV coordinates
  • Correct mapping in the UV coordinates
  • Fix typo in Azimuth

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen labels Apr 10, 2021
@OptimisticPeach
Fix IcoSphere UV coordinates
006e929 
Changes made:
- Swap Y/Z when calculating UV coordinates
- Correct mapping in the UV coordinates
- Fix type in Azimuth
@cart
Copy link
Member

cart commented Apr 14, 2021

bors r+

bors bot pushed a commit that referenced this pull request Apr 14, 2021
@OptimisticPeach
Fix IcoSphere UV coordinates (#1871)
df3f40a 
Changes made:
- Swap Y/Z when calculating UV coordinates
- Correct mapping in the UV coordinates
- Fix typo in Azimuth
@bors
Copy link
Contributor

bors bot commented Apr 14, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix IcoSphere UV coordinates [Merged by Bors] - Fix IcoSphere UV coordinates Apr 14, 2021
@bors bors bot closed this Apr 14, 2021
ostwilkens pushed a commit to ostwilkens/bevy that referenced this pull request Jul 27, 2021
@OptimisticPeach @ostwilkens
Fix IcoSphere UV coordinates (bevyengine#1871)
99430b9 
Changes made:
- Swap Y/Z when calculating UV coordinates
- Correct mapping in the UV coordinates
- Fix typo in Azimuth
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@nside nside nside approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@OptimisticPeach @cart @nside @mockersf @alice-i-cecile