Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - par_for_each: split batches when iterating on a sparse query #1945

Closed
wants to merge 2 commits into from

Conversation

mockersf
Copy link
Member

Fixes #1943

Each batch was iterating over the complete query

@mockersf mockersf force-pushed the par_for_each_check_offset branch from 345c956 to 36e3c0a Compare April 16, 2021 23:29
@mockersf mockersf added C-Bug An unexpected or incorrect behavior A-ECS Entities, components, systems, and events labels Apr 16, 2021
@mockersf mockersf force-pushed the par_for_each_check_offset branch from 35c931b to 78ed524 Compare April 17, 2021 00:04
@mockersf mockersf force-pushed the par_for_each_check_offset branch from 78ed524 to 48062c8 Compare April 17, 2021 00:05
@mockersf mockersf changed the title split batches when iterating on a non dense query par_for_each: split batches when iterating on a sparse query Apr 17, 2021
@alice-i-cecile alice-i-cecile added the P-High This is particularly urgent, and deserves immediate attention label Apr 17, 2021
@alice-i-cecile
Copy link
Member

Added high impact label due to UB :)

@cart
Copy link
Member

cart commented Apr 19, 2021

Thats a pretty nasty one. Thanks for looking in to this!

@cart
Copy link
Member

cart commented Apr 19, 2021

bors r+

bors bot pushed a commit that referenced this pull request Apr 19, 2021
Fixes #1943 

Each batch was iterating over the complete query
@bors bors bot changed the title par_for_each: split batches when iterating on a sparse query [Merged by Bors] - par_for_each: split batches when iterating on a sparse query Apr 19, 2021
@bors bors bot closed this Apr 19, 2021
ostwilkens pushed a commit to ostwilkens/bevy that referenced this pull request Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior P-High This is particularly urgent, and deserves immediate attention
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Heap corruption in par_for_each_mut
3 participants