[Merged by Bors] - update for wgpu 0.8 #1959
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
A-Rendering
|
feature |
|
wgpu 0.8 has been released 🎉 |
|
updated to 0.8! examples fails to run with but didn't find yet any place where we put |
|
fixed above issue by setting all sampler bindings to filtering |
cart
reviewed
Apr 30, 2021
cart
reviewed
Apr 30, 2021
|
I think in general we should probably just rename our types to match wgpu. Mirroring makes it easier for concepts to transfer. |
|
There's a whole bunch more validation in wgpu-0.8, it would be really nice to upgrade just for that alone. |
|
I think I renamed everything following the changes in |
cart
reviewed
May 2, 2021
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 2, 2021
Changes to get Bevy to compile with wgpu master. With this, on a Mac: * 2d examples look fine * ~~3d examples crash with an error specific to metal about a compilation error~~ * 3d examples work fine after enabling feature `wgpu/cross` Feature `wgpu/cross` seems to be needed only on some platforms, not sure how to know which. It was introduced in gfx-rs/wgpu-rs#826
|
Pull request successfully merged into main. Build succeeded: |
ostwilkens
pushed a commit
to ostwilkens/bevy
that referenced
this pull request
Jul 27, 2021
Changes to get Bevy to compile with wgpu master. With this, on a Mac: * 2d examples look fine * ~~3d examples crash with an error specific to metal about a compilation error~~ * 3d examples work fine after enabling feature `wgpu/cross` Feature `wgpu/cross` seems to be needed only on some platforms, not sure how to know which. It was introduced in gfx-rs/wgpu-rs#826
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to get Bevy to compile with wgpu master.
With this, on a Mac:
3d examples crash with an error specific to metal about a compilation errorwgpu/crossFeature
wgpu/crossseems to be needed only on some platforms, not sure how to know which. It was introduced in gfx-rs/wgpu-rs#826