Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix mouse_clicked check for touches. #2029

Closed
wants to merge 1 commit into from

Conversation

nihohit
Copy link
Contributor

@nihohit nihohit commented Apr 27, 2021

This seems like a copy-paste from line 72 that was only partially modified.

I don't know how to test this, so please verify me :)

This seems like a copy-paste from line 72 that was only partially modified.

I don't know how to test this, so please verify me :)
@cart
Copy link
Member

cart commented Apr 27, 2021

Yup this looks correct to me, but we'll want someone with a touch screen to validate. I'd run this on my android phone, but currently android builds are broken :)

@Moxinilian Moxinilian added C-Bug An unexpected or incorrect behavior A-Input Player input via keyboard, mouse, gamepad, and more labels Apr 27, 2021
@mockersf mockersf added the S-Pre-Relicense This PR was made before Bevy added the Apache license. Cannot be merged or used for other work label Jul 17, 2021
@alice-i-cecile
Copy link
Member

@nihohit, can you comment in #2373? We've since relicensed to MIT + Apache, and I'd like to either ensure that this can be picked up or close it out.

@nihohit
Copy link
Contributor Author

nihohit commented Apr 25, 2022

@alice-i-cecile done

@alice-i-cecile alice-i-cecile removed the S-Pre-Relicense This PR was made before Bevy added the Apache license. Cannot be merged or used for other work label Apr 25, 2022
@alice-i-cecile alice-i-cecile added O-Android Specific to the Android mobile operating system O-iOS Specific to the iOS mobile operating system labels May 16, 2022
@alice-i-cecile
Copy link
Member

bors r+

@alice-i-cecile
Copy link
Member

This is a trivial fix: we were triggering on button presses on touch releases, rather than touch presses. This is obviously incorrect.

bors bot pushed a commit that referenced this pull request May 16, 2022
This seems like a copy-paste from line 72 that was only partially modified.

I don't know how to test this, so please verify me :)
@bors bors bot changed the title Fix mouse_clicked check for touches. [Merged by Bors] - Fix mouse_clicked check for touches. May 16, 2022
@bors bors bot closed this May 16, 2022
robtfm pushed a commit to robtfm/bevy that referenced this pull request May 17, 2022
This seems like a copy-paste from line 72 that was only partially modified.

I don't know how to test this, so please verify me :)
exjam pushed a commit to exjam/bevy that referenced this pull request May 22, 2022
This seems like a copy-paste from line 72 that was only partially modified.

I don't know how to test this, so please verify me :)
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
This seems like a copy-paste from line 72 that was only partially modified.

I don't know how to test this, so please verify me :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Input Player input via keyboard, mouse, gamepad, and more C-Bug An unexpected or incorrect behavior O-Android Specific to the Android mobile operating system O-iOS Specific to the iOS mobile operating system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants