Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace vector of UniformProperty with a single UniformProperty #203

Merged
merged 1 commit into from
Aug 18, 2020

Conversation

lachlansneff
Copy link
Contributor

bevy_render::BindGroup::Uniform originally looked like this:

pub enum BindType {
    Uniform {
        dynamic: bool,
        properties: Vec<UniformProperty>,
    },
    ...
}

It turns out that properties doesn't need to be a vector, a struct is already a valid variant of UniformProperty.

So, this pr renames it to property and makes it a single item.

@karroffel karroffel added C-Feature A new feature, making something new possible A-Rendering Drawing game state to the screen labels Aug 16, 2020
@lachlansneff
Copy link
Contributor Author

I know you're extremely busy @cart, but it would be awesome to have this merged so I can start working on expanding the uniform types supported by bevy.

@cart
Copy link
Member

cart commented Aug 18, 2020

Sure thing. This is an easy win!

I have one more thing to wrap up then I'm going to be working full time to work through the PR / issue backlog

@cart cart merged commit 6ffe069 into bevyengine:master Aug 18, 2020
@multun multun mentioned this pull request Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Feature A new feature, making something new possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants