-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Implement Debug for Res and ResMut #2050
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As I mentioned in #2048, could you quickly add this for NonSend, NonSendMut and Local as well? Should be identical as I understand it. |
… like the other implementations
Done. There was already an implementation for NonSendMut, but I updated it to show the wrapper, like the others. |
forbjok
force-pushed
the
impl-debug-for-res-and-resmut
branch
from
April 29, 2021 17:39
6852fcc
to
ebfb61a
Compare
alice-i-cecile
approved these changes
Apr 29, 2021
alice-i-cecile
added
A-ECS
Entities, components, systems, and events
C-Usability
A targeted quality-of-life change that makes Bevy easier to use
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
labels
Apr 29, 2021
NathanSWard
reviewed
Apr 29, 2021
alice-i-cecile
added
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
and removed
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
labels
Apr 29, 2021
mockersf
requested changes
Apr 30, 2021
forbjok
force-pushed
the
impl-debug-for-res-and-resmut
branch
from
April 30, 2021 14:47
3b36979
to
984a174
Compare
mockersf
approved these changes
Apr 30, 2021
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 1, 2021
This commit adds blanket implementations of Debug for Res and ResMut, as discussed in #2048.
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Implement Debug for Res and ResMut
[Merged by Bors] - Implement Debug for Res and ResMut
May 1, 2021
ostwilkens
pushed a commit
to ostwilkens/bevy
that referenced
this pull request
Jul 27, 2021
This commit adds blanket implementations of Debug for Res and ResMut, as discussed in bevyengine#2048.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-ECS
Entities, components, systems, and events
C-Usability
A targeted quality-of-life change that makes Bevy easier to use
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds blanket implementations of Debug for Res and ResMut, as discussed in #2048.