Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Implement Debug for Res and ResMut #2050

Closed

Conversation

forbjok
Copy link
Contributor

@forbjok forbjok commented Apr 29, 2021

This commit adds blanket implementations of Debug for Res and ResMut, as discussed in #2048.

@alice-i-cecile
Copy link
Member

As I mentioned in #2048, could you quickly add this for NonSend, NonSendMut and Local as well? Should be identical as I understand it.

@forbjok
Copy link
Contributor Author

forbjok commented Apr 29, 2021

Done. There was already an implementation for NonSendMut, but I updated it to show the wrapper, like the others.

@forbjok forbjok force-pushed the impl-debug-for-res-and-resmut branch from 6852fcc to ebfb61a Compare April 29, 2021 17:39
@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Apr 29, 2021
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Apr 29, 2021
@forbjok forbjok force-pushed the impl-debug-for-res-and-resmut branch from 3b36979 to 984a174 Compare April 30, 2021 14:47
@forbjok forbjok requested a review from mockersf April 30, 2021 14:49
@cart
Copy link
Member

cart commented May 1, 2021

bors r+

bors bot pushed a commit that referenced this pull request May 1, 2021
This commit adds blanket implementations of Debug for Res and ResMut, as discussed in #2048.
@bors bors bot changed the title Implement Debug for Res and ResMut [Merged by Bors] - Implement Debug for Res and ResMut May 1, 2021
@bors bors bot closed this May 1, 2021
ostwilkens pushed a commit to ostwilkens/bevy that referenced this pull request Jul 27, 2021
This commit adds blanket implementations of Debug for Res and ResMut, as discussed in bevyengine#2048.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants