Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add non-overwriting variants of component/resource insertion functions #2061

Closed
wants to merge 8 commits into from
Closed

Add non-overwriting variants of component/resource insertion functions #2061

wants to merge 8 commits into from

Commits on May 1, 2021

  1. Add "try" variants to ecs insertion functions to control overwriting … 

    …behaviour
    @GarettCooper
    GarettCooper committed May 1, 2021
    Configuration menu
    Copy the full SHA
    8245efc View commit details
    Browse the repository at this point in the history

  2. Make documentation wording consistent between insert/insert_bundle an… 

    …d their try equivalents
    @GarettCooper
    GarettCooper committed May 1, 2021
    Configuration menu
    Copy the full SHA
    be5ffbd View commit details
    Browse the repository at this point in the history

  3. Add dedicated tests for try_insert

    @GarettCooper
    GarettCooper committed May 1, 2021
    Configuration menu
    Copy the full SHA
    0533c66 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2021

  1. Remove "write_additional_components" and use enum for control flow

    @GarettCooper
    GarettCooper committed May 3, 2021
    Configuration menu
    Copy the full SHA
    36d6509 View commit details
    Browse the repository at this point in the history

  2. Add tests for both "try_insert_resource" cases

    @GarettCooper
    GarettCooper committed May 3, 2021
    Configuration menu
    Copy the full SHA
    625dd43 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary code duplication in BundleInfo::write_components

    @GarettCooper
    GarettCooper committed May 3, 2021
    Configuration menu
    Copy the full SHA
    38e838a View commit details
    Browse the repository at this point in the history

  4. Rename ComponentCollision to CollisionBehaviour

    @GarettCooper
    GarettCooper committed May 3, 2021
    Configuration menu
    Copy the full SHA
    b74725d View commit details
    Browse the repository at this point in the history

  5. Correct string provided for .expect calls on resource access

    @GarettCooper
    GarettCooper committed May 3, 2021
    Configuration menu
    Copy the full SHA
    2e4f596 View commit details
    Browse the repository at this point in the history