[Merged by Bors] - Alien cake addict: Allow holding movement keys #2072
Conversation
|
please no WASD 😞 |
Why? |
|
Because it doesn't make any sense on anything but QWERTY. |
|
Also works for QWERTZ, but until we have a position based keyboard input system this is probably the best we can do. |
|
because it's not the best we can do, supporting wasd makes a lot of games unplayable without changing layout and it's not something I would like to promote in the examples. best we can do is arrows |
I feel like it will be hard to do until Bevy has something like https://docs.unity3d.com/Packages/com.unity.inputsystem@1.1/manual/Keyboard.html
But for me Also is this meant as PR feedback or just as a discussion? |
Both: I would really like to not have this in the example, but I can understand it makes sense for part of the world. I also hold no special power to stop it, so it's just my preference. And it's not on a technical point, so I won't put it as a review asking for change. Just a very strong opinion and preference on my side |
|
I feel like it's worth it since it makes the game nicer for people with And I don't feel bad about having this code in the examples (where it might be copied from) because we can't really tell developers not to use |
|
I was interested so googled it, and it appears the french keyboard is the only standardized keyboard that isn't qwerty/qwertz. Regardless of that fact, my 60% keyboard doesn't have arrow keys, so that isn't standardized either. If those keys aren't being used for anything else in the demonstration, and the fact that 98% of keyboards would match the schema, I, personally at least, see no harm in it being added especially since it's not like the arrow keys are no longer used. |
Then it makes sense, I'll go back to my French corner with my French keyboard... |
|
@mockersf your "french keyboard perspective" would be valuable in this conversation: #2052. I'm particularly curious about the physical positions of "scan codes" on french keyboards. WASD KeyCodes don't just alienate french people. They also alienate "alternative keyboard layout users" like dvorak and colemak. I think we should resolve the "physical key position" conversation in #2052 before making a call on WASD KeyCodes here. Using a pattern in an example is akin to endorsing that pattern and we should encourage people to do the "right thing" here (whatever that ends up being). |
|
(of course supporting re-mapping is a critical part of the "final" solution) |
cart
added
the
S-Pre-Relicense
mockersf
removed
the
S-Pre-Relicense
The WASD keys are convenient for QWERTY keyboards, but this might not be the case for other layouts. Until there is a way to use key positions instead of letters we will not showcase it in examples.
RedlineTriad
changed the title
|
bors try |
|
Tested locally; this feels much better and is now just uncontroversial QoL and code quality fixes. |
|
bors r+ |
I wanted to try one of the new examples but it felt so clunky that I wanted to improve it. It did make me feel like maybe some input axes abstraction like Unity has might be useful. Also, eating cake should probably be a separate system from movement.
bors
bot
changed the title
I wanted to try one of the new examples but it felt so clunky that I wanted to improve it.
It did make me feel like maybe some input axes abstraction like Unity has might be useful.
Also, eating cake should probably be a separate system from movement.