-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Move to smallvec v1.6 #2074
Conversation
Since we're already using latest stable, should be enable the |
yes for no for |
The docs aren't up-to-date: in 1.6, it compiles on stable :) |
Ooh yeah lets enables those features :) |
Hmm, what would be a good place to enable these features? I'm adding a |
Hmm I think it doesn't matter too much as features are merged across dependencies. Keeping them in sync makes it easier to do a simple "search for Does smallvec respect the soft "features are additive only" rule or will enabling something like const_generics break apis that weren't coded to it? We could also consider re-exporting smallvec from |
From what I can see, |
I don't think that's necessary, those features will be enabled if someone import |
bors r+ |
Pull request successfully merged into main. Build succeeded: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi, i found these two instances of simple typo; cargo was complaining while I was trying to run examples.
smallvec = "1.4.2" | ||
# TODO: replace once_cell with std equivalent if/when this lands: https://github.com/rust-lang/rfcs/pull/2788 | ||
once_cell = "1.4.1" | ||
smallvec = { version = "1.6", feautres = ["union", "const_generics"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo found: feautres
=> features
.
cargo is complaining about this "unused manifest key."
smallvec = { version = "1.6", feautres = ["union", "const_generics"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo found: feautres
=> features
.
cargo is complaining about this "unused manifest key."
they could be fixed in #2111 |
No description provided.