Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - official 2D examples linked in rustdoc #2081

Closed
wants to merge 3 commits into from

Conversation

jak6jak
Copy link
Contributor

@jak6jak jak6jak commented May 2, 2021

I linked to examples within the rustdoc for the 2d examples as per issue #1934

@mockersf mockersf added C-Docs An addition or correction to our documentation C-Examples An addition or correction to our examples labels May 2, 2021
@@ -14,13 +14,17 @@ use bevy_render::{
};
use serde::{Deserialize, Serialize};


Copy link
Member

@mockersf mockersf May 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

this is what CI is failing over

@jak6jak
Copy link
Contributor Author

jak6jak commented May 5, 2021

I removed the white line. Does everything else look good? Any suggestions?

@cart
Copy link
Member

cart commented May 5, 2021

I think this is good to go!

@cart
Copy link
Member

cart commented May 5, 2021

bors r+

bors bot pushed a commit that referenced this pull request May 5, 2021
I linked to examples within the rustdoc for the 2d examples as per issue #1934
@bors bors bot changed the title official 2D examples linked in rustdoc [Merged by Bors] - official 2D examples linked in rustdoc May 5, 2021
@bors bors bot closed this May 5, 2021
ostwilkens pushed a commit to ostwilkens/bevy that referenced this pull request Jul 27, 2021
I linked to examples within the rustdoc for the 2d examples as per issue bevyengine#1934
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Docs An addition or correction to our documentation C-Examples An addition or correction to our examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants