Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Add file metadata to AssetIo #2123

Closed
wants to merge 10 commits into from

Conversation

geckoxx
Copy link
Contributor

@geckoxx geckoxx commented May 6, 2021

This is a replacement for #2106

This adds a Metadata struct which contains metadata information about a file, at the moment only the file type.
It also adds a get_metadata to AssetIo trait and an asset_io accessor method to AssetServer and LoadContext

I am not sure about the changes in AndroidAssetIo and WasmAssetIo.

@alice-i-cecile alice-i-cecile added A-Assets Load files from disk to use for things like images, models, and sounds C-Feature A new feature, making something new possible labels May 6, 2021
@NathanSWard
Copy link
Contributor

bors try

bors bot added a commit that referenced this pull request May 18, 2021
@mockersf mockersf added S-Pre-Relicense This PR was made before Bevy added the Apache license. Cannot be merged or used for other work S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Jul 16, 2021
@mockersf
Copy link
Member

@geckoxx hey! If you're around, could you comment on #2373 about the license change? I don't think I saw your name there. Thanks!

@geckoxx
Copy link
Contributor Author

geckoxx commented Apr 12, 2022

@geckoxx hey! If you're around, could you comment on #2373 about the license change? I don't think I saw your name there. Thanks!

Done

@mockersf mockersf removed the S-Pre-Relicense This PR was made before Bevy added the Apache license. Cannot be merged or used for other work label Apr 13, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request May 2, 2022
This is a replacement for #2106

This adds a `Metadata` struct which contains metadata information about a file, at the moment only the file type.
It also adds a `get_metadata` to `AssetIo` trait and an `asset_io` accessor method to `AssetServer` and `LoadContext`

I am not sure about the changes in `AndroidAssetIo ` and `WasmAssetIo`.
@bors bors bot changed the title Add file metadata to AssetIo [Merged by Bors] - Add file metadata to AssetIo May 2, 2022
@bors bors bot closed this May 2, 2022
exjam pushed a commit to exjam/bevy that referenced this pull request May 22, 2022
This is a replacement for bevyengine#2106

This adds a `Metadata` struct which contains metadata information about a file, at the moment only the file type.
It also adds a `get_metadata` to `AssetIo` trait and an `asset_io` accessor method to `AssetServer` and `LoadContext`

I am not sure about the changes in `AndroidAssetIo ` and `WasmAssetIo`.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
This is a replacement for bevyengine#2106

This adds a `Metadata` struct which contains metadata information about a file, at the moment only the file type.
It also adds a `get_metadata` to `AssetIo` trait and an `asset_io` accessor method to `AssetServer` and `LoadContext`

I am not sure about the changes in `AndroidAssetIo ` and `WasmAssetIo`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Feature A new feature, making something new possible S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants