[Merged by Bors] - expose texture/image conversions as From/TryFrom #2175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanSWard
reviewed
May 16, 2021
NathanSWard
reviewed
May 16, 2021
alice-i-cecile
added
C-Feature
NathanSWard
suggested changes
May 16, 2021
NathanSWard
approved these changes
May 16, 2021
Co-authored-by: Nathan Ward <43621845+NathanSWard@users.noreply.github.com>
alice-i-cecile
approved these changes
May 19, 2021
alice-i-cecile
added
the
S-Ready-For-Final-Review
|
Love it! |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jun 8, 2021
fixes #2169 Instead of having custom methods with reduced visibility, implement `From<image::DynamicImage> for Texture` and `TryFrom<Texture> for image::DynamicImage`
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
ostwilkens
pushed a commit
to ostwilkens/bevy
that referenced
this pull request
Jul 27, 2021
fixes bevyengine#2169 Instead of having custom methods with reduced visibility, implement `From<image::DynamicImage> for Texture` and `TryFrom<Texture> for image::DynamicImage`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2169
Instead of having custom methods with reduced visibility, implement
From<image::DynamicImage> for TextureandTryFrom<Texture> for image::DynamicImage