Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Bump winit to 0.25 #2186

Closed
wants to merge 2 commits into from

Conversation

gcoakes
Copy link
Contributor

@gcoakes gcoakes commented May 16, 2021

winit v0.25 includes support for propagating mouse motion events in the HTML canvas to the winit window.

@mockersf mockersf added dependencies A-Windowing Platform-agnostic interface layer to run your app in labels May 16, 2021
@mockersf
Copy link
Member

@mockersf
Copy link
Member

mockersf commented May 17, 2021

dependant also opened that PR to update winit and found issues in the wasm build: https://github.com/bevyengine/bevy/pull/2194/checks?check_run_id=2597775798

Can you fix those?

failures were because dependabot didn't update all references to winit, which you did 🎉

@mockersf
Copy link
Member

bors try

bors bot added a commit that referenced this pull request May 17, 2021
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label May 17, 2021
@cart
Copy link
Member

cart commented May 18, 2021

bors r+

bors bot pushed a commit that referenced this pull request May 18, 2021
winit v0.25 includes support for propagating mouse motion events in the HTML canvas to the winit window.
@bors bors bot changed the title Bump winit to 0.25 [Merged by Bors] - Bump winit to 0.25 May 18, 2021
@bors bors bot closed this May 18, 2021
bors bot pushed a commit that referenced this pull request May 18, 2021
After winit update in #2186, a bunch of duplicated dependencies changed.

Most are related to a new dependency, https://github.com/onurzdg/mio-misc, that has a few older versions in its dependencies
ostwilkens pushed a commit to ostwilkens/bevy that referenced this pull request Jul 27, 2021
winit v0.25 includes support for propagating mouse motion events in the HTML canvas to the winit window.
ostwilkens pushed a commit to ostwilkens/bevy that referenced this pull request Jul 27, 2021
After winit update in bevyengine#2186, a bunch of duplicated dependencies changed.

Most are related to a new dependency, https://github.com/onurzdg/mio-misc, that has a few older versions in its dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Windowing Platform-agnostic interface layer to run your app in S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants