Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Expose set_changed() on ResMut and Mut #2208

Closed

Conversation

NathanSWard
Copy link
Contributor

This new api stems from this discord conversation.

This exposes a public facing set_changed method on ResMut and Mut.

As a side note: ResMut and Mut have a lot of duplicated code, I have a PR I may put up later that refactors these commonalities into a trait.

@NathanSWard NathanSWard added A-ECS Entities, components, systems, and events C-Feature A new feature, making something new possible labels May 18, 2021
@alice-i-cecile
Copy link
Member

As a side note: ResMut and Mut have a lot of duplicated code, I have a PR I may put up later that refactors these commonalities into a trait.

Yep! That was part of the inspiration behind #2189, which you may find useful.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label May 18, 2021
@cart
Copy link
Member

cart commented May 18, 2021

bors r+

bors bot pushed a commit that referenced this pull request May 18, 2021
This new api stems from this [discord conversation](https://discord.com/channels/691052431525675048/742569353878437978/844057268172357663).

This exposes a public facing `set_changed` method on `ResMut` and `Mut`.

As a side note: `ResMut` and `Mut` have a lot of duplicated code, I have a PR I may put up later that refactors these commonalities into a trait.

Co-authored-by: Carter Anderson <mcanders1@gmail.com>
@bors bors bot changed the title Expose set_changed() on ResMut and Mut [Merged by Bors] - Expose set_changed() on ResMut and Mut May 18, 2021
@bors bors bot closed this May 18, 2021
ostwilkens pushed a commit to ostwilkens/bevy that referenced this pull request Jul 27, 2021
This new api stems from this [discord conversation](https://discord.com/channels/691052431525675048/742569353878437978/844057268172357663).

This exposes a public facing `set_changed` method on `ResMut` and `Mut`.

As a side note: `ResMut` and `Mut` have a lot of duplicated code, I have a PR I may put up later that refactors these commonalities into a trait.

Co-authored-by: Carter Anderson <mcanders1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events C-Feature A new feature, making something new possible S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants