Android support

[TheRawMeatball]

Improves situation on #86

Current status: Occasional panics when resuming, needs #2300.

[cart]

Switch to using stdout logging on android

Can you elaborate a bit on what motivated this decision? I'm assuming android_log-sys was causing problems? Losing "native android log levels" isn't ideal.

[TheRawMeatball]

I'm not sure why, but it didn't work properly for me. And given that stdout is already redirected, a consistent output is more appealing to me - the command adb logcat -v raw RustStdoutStderr:D *:S gives exactly what you'd get if you were running the game on the PC.

[cart]

I think being able to use UI to toggle logs by their level is way more valuable than exact consistency with pc console logs. The android ides I've used all support this for "native android logs". I also think theres a good chance that we will ultimately have a custom tracing backend for the bevy editor that collects a "structured log format" instead of stdout.

Obviously being able to run android apps is more important than this, but I'm still very much in favor of retaining native logging if possible.

[TheRawMeatball]

Hmm, I experimented with it a bit more, and personally I'm still in favor of defaulting android to stdout, since right now getting a clean output from adb logcat is not super easy. We should consider that most people may not want to set up a full Android IDE, and want to just quickly debug something. I'll probably put the android logger impl behind a feature flag and default to stdout. Would that be an OK compromise?

[cart]

since right now getting a clean output from adb logcat is not super easy

Can you elaborate a bit on this? I wouldn't call adb logcat -v raw RustStdoutStderr:D *:S particularly "easy" either. I've successfully used adb logcat with the native logger (by just scrolling to my app logs).

[TheRawMeatball]

It's more of an I haven't been able to figure it out yet 😅. I tried a bunch of stuff for cleaning up the logs, but there was still random irrelevant logs coming in. Especially for a game, where my debugging strategy tends to be spam the console and use it as a real time display, scrolling isn't an option, and random logs coming in can make the text jittery.

[cart]

This stackoverflow thread seems to have a number of options which are approximately as complex as adb logcat -v raw RustStdoutStderr:D *:S:

https://stackoverflow.com/questions/6854127/filter-logcat-to-get-only-the-messages-from-my-application-in-android

[TheRawMeatball]

These still gave pings from android s vulkan layer :/.

[cart]

bors try

[cart]

(I'm hitting shaderc complication errors on my system and I'm curious to see if bors hits them too)

[cart]

Yeah I think the issue is that we need all(target_arch="armv7", target_os="androideabi") in cargo.toml instead of all(target_arch="armv7", target_os="androidabi")

[bors]

try

Build succeeded:

• check-missing-examples-in-docs
• check-markdown-links
• build-wasm (stable, ubuntu-latest)
• build (stable, macos-latest)
• check-doc
• build (nightly, ubuntu-latest)
• run-examples
• build-android
• markdownlint
• build-wasm (nightly, ubuntu-latest)
• build (stable, windows-latest)
• build (stable, ubuntu-latest)

[cart]

Hmm i guess this is a "cart's machine" problem. It is weird that shaderc is getting compiled at all? Shouldn't we be using glsl-to-spirv?

[TheRawMeatball]

Maybe we wait until after the renderer rework and don't have to bother with shaderc at all?

[cart]

I like this plan :)

[billyb2]

Just out of curiosity, when will said rework probably come? (Very excited for Android support in Bevy, and it will make it easily the best Rust game engine imho).

[cart]

Hard to say, but ideally within the next month.

[billyb2]

Alright, thank you!

[TheRawMeatball]

#2482 has done most of what this PR does, closing.