Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix view vector in pbr frag to work in ortho #2370

Closed
wants to merge 1 commit into from

Conversation

aevyrie
Copy link
Member

@aevyrie aevyrie commented Jun 21, 2021

Objective

Fixes #2369

Solution

Use the view forward direction for all frags when using ortho view.

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Jun 21, 2021
@mockersf
Copy link
Member

before

before

after

after

@NathanSWard NathanSWard added A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior and removed S-Needs-Triage This issue needs to be labelled labels Jun 21, 2021
@cart
Copy link
Member

cart commented Jul 1, 2021

bors r+

bors bot pushed a commit that referenced this pull request Jul 1, 2021
# Objective

Fixes #2369

## Solution

Use the view forward direction for all frags when using ortho view.
@bors bors bot changed the title Fix view vector in pbr frag to work in ortho [Merged by Bors] - Fix view vector in pbr frag to work in ortho Jul 1, 2021
@bors bors bot closed this Jul 1, 2021
ostwilkens pushed a commit to ostwilkens/bevy that referenced this pull request Jul 27, 2021
# Objective

Fixes bevyengine#2369

## Solution

Use the view forward direction for all frags when using ortho view.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Fresnel for Ortho Projections
4 participants