Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add an option about display server protocol, and create document docs/cargo_features.md #249

Merged
merged 8 commits into from
Aug 25, 2020
Merged

add an option about display server protocol, and create document docs/cargo_features.md #249

merged 8 commits into from
Aug 25, 2020

Conversation

VitalyAnkh
Copy link
Contributor

add an option --features wayland or features x11

@VitalyAnkh VitalyAnkh changed the title add and option to allow application run on wayland or x11 add an option to allow application run on wayland or x11 Aug 19, 2020
@multun
Copy link
Contributor

multun commented Aug 19, 2020

LGTM, can't test it right now

@karroffel karroffel added C-Dependencies A change to the crates that Bevy depends on A-Windowing Platform-agnostic interface layer to run your app in labels Aug 20, 2020
cart
cart reviewed Aug 20, 2020
View reviewed changes
examples/README.md
@@ -1,7 +1,10 @@
# Examples

These examples demonstrate the main features of Bevy and how to use them.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would prefer to leave non-default feature documentation out of the README. Instead, lets create a new docs/features.md file and link to it from the readme.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cart Done! I create a new docs/features.md file and link to it from the readme.

The suggestions in examples/README.md is reversed for I think it's useful for people who are not familiar with cargo.

How do you like it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just one small set of changes: lets rename the file cargo_features.md, make the title # Cargo Features and then in the main readme make it ## [Bevy Cargo Features](docs/cargo_features.md)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@VitalyAnkh VitalyAnkh changed the title add an option to allow application run on wayland or x11 add an option about display server protocol, and create document docs/features.md Aug 21, 2020
@VitalyAnkh VitalyAnkh changed the title add an option about display server protocol, and create document docs/features.md add an option about display server protocol, and create document docs/cargo_features.md Aug 22, 2020
VitalyAnkh
VitalyAnkh commented Aug 22, 2020
View reviewed changes
Copy link
Contributor Author

@VitalyAnkh VitalyAnkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I'm going to learn the normay way to resolve merge conflicts. Stay tuned.

@VitalyAnkh
Copy link
Contributor Author

Merge conflicts resolved! I'm looking into the check fails...

@VitalyAnkh VitalyAnkh requested a review from cart August 22, 2020 07:20
@cart
Copy link
Member

cart commented Aug 22, 2020

The build break is my fault! This should be good to go. I'll do some validation myself.

@cart cart merged commit c78187e into bevyengine:master Aug 25, 2020
BimDav pushed a commit to BimDav/bevy that referenced this pull request Aug 26, 2020
@VitalyAnkh @BimDav
add an option about display server protocol, and create document `doc…
ccd06de 
…s/cargo_features.md` (bevyengine#249)

add an option about display server protocol, and create document `docs/cargo_features.md`
@mikekreuzer mikekreuzer mentioned this pull request Sep 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cart cart cart approved these changes

Assignees
No one assigned
Labels
A-Windowing Platform-agnostic interface layer to run your app in C-Dependencies A change to the crates that Bevy depends on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VitalyAnkh @multun @cart @karroffel