-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Relicense bors checks #2493
Conversation
Not a fan of the auto label but it makes sense and shouldn't be for long |
Ok, here's a weird thing - this PR hasn't been automatically labelled with |
Yes, indeed. The automatic labelling is only temporary. I'd rather make sure that we don't have any false approvals again, so it's best to check. |
That shouldn't come from the change in this PR as the label workflow is |
Ok, this is 'expected' - actions/labeler doesn't match files/folders starting with a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely better to remove a few premature labels than to merge a PR and then have to run after the contributor to approve the license change 👍
bors r+ |
# Objective Currently we can sometimes allow PRs by people who haven't agreed to the relicense to get merged into main. E.g. #2445 ## Solution This adds a check to ensure that this doesn't happen, by ensuring that bors doesn't relicense said PRs. As a bonus, it also adds config to automatically label new PRs as needing checking, to ensure that we do the verification until we merge the new license.
# Objective Currently we can sometimes allow PRs by people who haven't agreed to the relicense to get merged into main. E.g. bevyengine#2445 ## Solution This adds a check to ensure that this doesn't happen, by ensuring that bors doesn't relicense said PRs. As a bonus, it also adds config to automatically label new PRs as needing checking, to ensure that we do the verification until we merge the new license.
Objective
Currently we can sometimes allow PRs by people who haven't agreed to the relicense to get merged into main.
E.g. #2445
Solution
This adds a check to ensure that this doesn't happen, by ensuring that bors doesn't relicense said PRs.
As a bonus, it also adds config to automatically label new PRs as needing checking, to ensure that we do the verification until we merge the new license.