Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a System Builder Syntax instead of using System Descriptors #2736
Create a System Builder Syntax instead of using System Descriptors #2736
Changes from 1 commit
0c6a837
569513c
983a2be
abd6d8b
52e7fff
011af54
ecb855b
20fd625
d9f7558
e83c519
b540f79
3bad094
325689b
9aeb408
d7e1e2a
4514032
251fb40
0995f85
2d062e6
9a2284e
5487f83
1d34d96
9822b19
e80fded
7b4bb30
aee8c9d
eb207e5
0c9ac6a
6c28d69
085a5ef
55b797c
c8914c1
0a32358
0f6494b
91cb4c2
b272cb4
cf372a7
25b1d31
d360e14
a762965
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this could keep a reference to the conflicting stage name and add that to the panic message.
Small suggestion, you could use this instead
conflict = set.systems.iter().any(|system| system.config().stage != set.config().stage);
, but that's entirely up to preference.