Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix panic on is_resource_* calls (#2828) #2863

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Fix panic on is_resource_* calls (#2828) #2863

wants to merge 1 commit into from

Conversation

dixonwille
Copy link
Contributor

Changed out unwraps to use if let syntax instead. Returning false when None.

Also modified an existing test to encompass these methods

This PR fixes #2828

@dixonwille
Fix panic on is_resource_* calls (bevyengine#2828)
80e1cba 
Changed out unwraps to use if let syntax instead. Returning false when None.

Also modified an existing test to encompass these methods

This PR fixes bevyengine#2828
@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Sep 24, 2021
@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior C-Code-Quality A section of code that is hard to understand or change S-Needs-Review and removed S-Needs-Triage This issue needs to be labelled labels Sep 24, 2021
@cart
Copy link
Member

cart commented Sep 24, 2021

Very good call!

@cart
Copy link
Member

cart commented Sep 24, 2021

bors r+

bors bot pushed a commit that referenced this pull request Sep 24, 2021
@dixonwille
Fix panic on is_resource_* calls (#2828) (#2863)
d158e08 
Changed out unwraps to use if let syntax instead. Returning false when None.

Also modified an existing test to encompass these methods

This PR fixes #2828
@bors
Copy link
Contributor

bors bot commented Sep 24, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix panic on is_resource_* calls (#2828) [Merged by Bors] - Fix panic on is_resource_* calls (#2828) Sep 24, 2021
@bors bors bot closed this Sep 24, 2021
@dixonwille dixonwille deleted the bug/is_resource-panic branch September 24, 2021 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior C-Code-Quality A section of code that is hard to understand or change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

app.world().is_resource_added::<T>() panics instead of returning false
3 participants
@dixonwille @cart @alice-i-cecile