-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - change texture atlas sprite indexing to usize #2887
Closed
hymm
wants to merge
3
commits into
bevyengine:pipelined-rendering
from
hymm:add-texture-returns-usize-index
Closed
[Merged by Bors] - change texture atlas sprite indexing to usize #2887
hymm
wants to merge
3
commits into
bevyengine:pipelined-rendering
from
hymm:add-texture-returns-usize-index
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inodentry
added
A-Rendering
Drawing game state to the screen
C-Code-Quality
A section of code that is hard to understand or change
S-Needs-Review
and removed
S-Needs-Triage
This issue needs to be labelled
labels
Oct 1, 2021
inodentry
approved these changes
Oct 1, 2021
mockersf
approved these changes
Oct 1, 2021
mockersf
added
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
and removed
S-Needs-Review
labels
Oct 1, 2021
mockersf
reviewed
Oct 15, 2021
hymm
force-pushed
the
add-texture-returns-usize-index
branch
from
October 16, 2021 18:35
3017d66
to
28ffc36
Compare
mockersf
approved these changes
Oct 16, 2021
hymm
force-pushed
the
add-texture-returns-usize-index
branch
from
October 29, 2021 15:49
28ffc36
to
b259b60
Compare
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 1, 2021
Per this comment #2864 (comment), I have done a pass at changing all the public facing indexes for `TextureAtlas` to usize.
Pull request successfully merged into pipelined-rendering. Build succeeded: |
bors
bot
changed the title
change texture atlas sprite indexing to usize
[Merged by Bors] - change texture atlas sprite indexing to usize
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Rendering
Drawing game state to the screen
C-Code-Quality
A section of code that is hard to understand or change
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per this comment #2864 (comment),
I have done a pass at changing all the public facing indexes for
TextureAtlas
to usize.