Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - change texture atlas sprite indexing to usize #2887

Conversation

hymm
Copy link
Contributor

@hymm hymm commented Sep 29, 2021

Per this comment #2864 (comment),
I have done a pass at changing all the public facing indexes for TextureAtlas to usize.

@hymm hymm changed the base branch from main to pipelined-rendering September 29, 2021 02:39
@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Sep 29, 2021
@inodentry inodentry added A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change S-Needs-Review and removed S-Needs-Triage This issue needs to be labelled labels Oct 1, 2021
@mockersf mockersf added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review labels Oct 1, 2021
@hymm hymm force-pushed the add-texture-returns-usize-index branch from 3017d66 to 28ffc36 Compare October 16, 2021 18:35
@hymm hymm force-pushed the add-texture-returns-usize-index branch from 28ffc36 to b259b60 Compare October 29, 2021 15:49
@cart
Copy link
Member

cart commented Nov 1, 2021

bors r+

bors bot pushed a commit that referenced this pull request Nov 1, 2021
Per this comment #2864 (comment),
I have done a pass at changing all the public facing indexes for `TextureAtlas` to usize.
@bors
Copy link
Contributor

bors bot commented Nov 1, 2021

@bors bors bot changed the title change texture atlas sprite indexing to usize [Merged by Bors] - change texture atlas sprite indexing to usize Nov 1, 2021
@bors bors bot closed this Nov 1, 2021
@hymm hymm deleted the add-texture-returns-usize-index branch November 5, 2021 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants