[Merged by Bors] - Fix bevy_ecs::schedule::executor_parallel::system span management #2905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Or at least bevy_ecs::schedule::executor_parallel::system Fixes bevyengine#2904
|
This has the concrete benefit that you can now write a log filter |
|
Would this be fixed by #2423 , or is it another span that didn't have its parent? If they are the same fix, yours is much simpler 👍 |
|
@mockersf these do seem to be the same issue! And yeah, I was glad to see that I could grab the TLS context so easily rather than having to thread the context through manually behind the cfg. |
NiklasEi
added
C-Usability
mockersf
approved these changes
Oct 4, 2021
NiklasEi
approved these changes
Oct 6, 2021
NiklasEi
added
S-Ready-For-Final-Review
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 6, 2021
) # Objective - Fixes #2904 (see for context) ## Solution - Simply hoist span creation out of the threaded task - Confirmed to solve the issue locally Now all events have the full span parent tree up through `bevy_ecs::schedule::stage` all the way to `bevy_app::app::bevy_app` (and its parents in bevy-consumer code, if any).
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Now all events have the full span parent tree up through
bevy_ecs::schedule::stageall the way tobevy_app::app::bevy_app(and its parents in bevy-consumer code, if any).