Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - use correct size of pixel instead of 4 #2977

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - use correct size of pixel instead of 4 #2977

wants to merge 1 commit into from

Conversation

mockersf
Copy link
Member

Objective

Solution

  • Replace the hard coded pixel with one using the texture pixel size

@mockersf mockersf mentioned this pull request Oct 15, 2021
Closed
@mockersf mockersf added A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior labels Oct 15, 2021
DJMcNab
DJMcNab approved these changes Oct 16, 2021
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it's ever possible to use new_fill correctly. I guess it should have an assert that the passed in slice matches the expected size.

Otherwise though this looks good.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 16, 2021
@cart
Copy link
Member

cart commented Oct 28, 2021

looks good to me!

@cart
Copy link
Member

cart commented Oct 28, 2021

bors r+

bors bot pushed a commit that referenced this pull request Oct 28, 2021
@mockersf
use correct size of pixel instead of 4 (#2977)
a2ea927 
# Objective

- Fixes #2919 
- Initial pixel was hard coded and not dependent on texture format
- Replace #2920 as I noticed this needed to be done also on pipeline rendering branch

## Solution

- Replace the hard coded pixel with one using the texture pixel size
@bors
Copy link
Contributor

bors bot commented Oct 28, 2021

Pull request successfully merged into pipelined-rendering.

Build succeeded:

@bors bors bot changed the title use correct size of pixel instead of 4 [Merged by Bors] - use correct size of pixel instead of 4 Oct 28, 2021
@bors bors bot closed this Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@IceSentry IceSentry IceSentry approved these changes

@DJMcNab DJMcNab DJMcNab approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mockersf @cart @alice-i-cecile @IceSentry @DJMcNab