-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Make the iter_combinators
examples more pretty
#3075
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Code-Quality
A section of code that is hard to understand or change
C-Examples
An addition or correction to our examples
S-Needs-Review
and removed
S-Needs-Triage
This issue needs to be labelled
labels
Nov 5, 2021
Screen.Recording.2021-11-06.at.00.37.45.mov |
mockersf
approved these changes
Jan 6, 2022
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jan 6, 2022
# Objective - More colours ## Solution - Various changes - Would have a video here, but don't have an easy way to record one before I go to sleep - I intend to additionally change the distribution of the satellites, to be more uniform in space.
Build failed: |
bors try |
tryBuild failed: |
mockersf
reviewed
Jan 6, 2022
mockersf
requested changes
Jan 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried running on rebased main, the light doesn't work anymore as it needs other components from the PointLightBundle
Could you apply this change to your PR branch?
--- a/examples/ecs/iter_combinations.rs
+++ b/examples/ecs/iter_combinations.rs
@@ -127,14 +127,19 @@ fn generate_bodies(
mass: Mass(500.0),
..Default::default()
})
- .insert(PointLight {
- color: Color::WHITE,
- intensity: 400.,
- range: 100.,
- radius: star_radius,
- ..Default::default()
- })
- .insert(Star);
+ .insert(Star)
+ .with_children(|p| {
+ p.spawn_bundle(PointLightBundle {
+ point_light: PointLight {
+ color: Color::WHITE,
+ intensity: 400.0,
+ range: 100.0,
+ radius: star_radius,
+ ..Default::default()
+ },
+ ..Default::default()
+ });
+ });
commands.spawn_bundle(PerspectiveCameraBundle {
transform: Transform::from_xyz(0.0, 10.5, -30.0).looking_at(Vec3::ZERO, Vec3::Y),
..Default::default()
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com> Co-authored-by: François <mockersf@gmail.com>
Co-authored-by: François <mockersf@gmail.com>
DJMcNab
force-pushed
the
combinators-pretty
branch
from
January 6, 2022 09:37
65d6342
to
4f1b2df
Compare
mockersf
approved these changes
Jan 6, 2022
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jan 6, 2022
# Objective - More colours ## Solution - Various changes - Would have a video here, but don't have an easy way to record one before I go to sleep - I intend to additionally change the distribution of the satellites, to be more uniform in space.
bors
bot
changed the title
Make the
[Merged by Bors] - Make the Jan 6, 2022
iter_combinators
examples more prettyiter_combinators
examples more pretty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-Code-Quality
A section of code that is hard to understand or change
C-Examples
An addition or correction to our examples
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution