Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - bevy_pbr2: Fix shadow logic #3186

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - bevy_pbr2: Fix shadow logic #3186

wants to merge 1 commit into from

Conversation

superdump
Copy link
Contributor

Objective

  • Shadow maps should only be sampled if the mesh is a shadow receiver AND shadow mapping is enabled for the light

Solution

  • Fix the logic in the shader

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Nov 25, 2021
@mockersf mockersf added A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior and removed S-Needs-Triage This issue needs to be labelled labels Nov 25, 2021
@mockersf mockersf mentioned this pull request Nov 26, 2021
Closed
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Nov 26, 2021
@mockersf
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Nov 26, 2021
@superdump
bevy_pbr2: Fix shadow logic (#3186)
f3d4be3 
# Objective

- Shadow maps should only be sampled if the mesh is a shadow receiver AND shadow mapping is enabled for the light

## Solution

- Fix the logic in the shader
@bors
Copy link
Contributor

bors bot commented Nov 26, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title bevy_pbr2: Fix shadow logic [Merged by Bors] - bevy_pbr2: Fix shadow logic Nov 26, 2021
@bors bors bot closed this Nov 26, 2021
HackerFoo pushed a commit to HackerFoo/bevy that referenced this pull request Nov 26, 2021
@superdump @HackerFoo
bevy_pbr2: Fix shadow logic (bevyengine#3186)
7dc4c5e 
# Objective

- Shadow maps should only be sampled if the mesh is a shadow receiver AND shadow mapping is enabled for the light

## Solution

- Fix the logic in the shader
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Davier Davier Davier approved these changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@superdump @mockersf @Davier