Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - More Bevy ECS schedule spans #3281

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - More Bevy ECS schedule spans #3281

wants to merge 1 commit into from

Conversation

cart
Copy link
Member

@cart cart commented Dec 8, 2021

Fills in some gaps we had in our Bevy ECS tracing spans:

  • Exclusive systems
  • System Commands (for apply_buffers = true cases)
  • System archetype updates
  • Parallel system execution prep

@cart cart added the A-ECS Entities, components, systems, and events label Dec 8, 2021
@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Dec 8, 2021
@alice-i-cecile alice-i-cecile added C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Needs-Review and removed S-Needs-Triage This issue needs to be labelled labels Dec 8, 2021
@cart
Copy link
Member Author

cart commented Dec 8, 2021

bors r+

bors bot pushed a commit that referenced this pull request Dec 8, 2021
@cart
More Bevy ECS schedule spans (#3281)
7dd92e7 
Fills in some gaps we had in our Bevy ECS tracing spans:

* Exclusive systems
* System Commands (for `apply_buffers = true` cases)
* System archetype updates
* Parallel system execution prep
@mockersf mockersf added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review labels Dec 8, 2021
@bors
Copy link
Contributor

bors bot commented Dec 8, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title More Bevy ECS schedule spans [Merged by Bors] - More Bevy ECS schedule spans Dec 8, 2021
@bors bors bot closed this Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@IceSentry IceSentry IceSentry approved these changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cart @alice-i-cecile @IceSentry @mockersf