Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - remove dead code: ShaderDefs derive #3490

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - remove dead code: ShaderDefs derive #3490

wants to merge 1 commit into from

Conversation

mockersf
Copy link
Member

Objective

  • remove some dead code and see if someone isn't happy about it

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Dec 29, 2021
@mockersf mockersf added C-Code-Quality A section of code that is hard to understand or change and removed S-Needs-Triage This issue needs to be labelled labels Dec 29, 2021
@mockersf mockersf mentioned this pull request Dec 29, 2021
Closed
@cart
Copy link
Member

cart commented Dec 29, 2021

bors r+

bors bot pushed a commit that referenced this pull request Dec 29, 2021
@mockersf
remove dead code: ShaderDefs derive (#3490)
d8d3fdf 
# Objective

- remove some dead code and see if someone isn't happy about it


Co-authored-by: François <8672791+mockersf@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Dec 29, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title remove dead code: ShaderDefs derive [Merged by Bors] - remove dead code: ShaderDefs derive Dec 29, 2021
@bors bors bot closed this Dec 29, 2021
mockersf added a commit to mockersf/bevy that referenced this pull request Jan 1, 2022
@mockersf
remove dead code: ShaderDefs derive (bevyengine#3490)
264d8f2 
# Objective

- remove some dead code and see if someone isn't happy about it


Co-authored-by: François <8672791+mockersf@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakobhellermann jakobhellermann jakobhellermann approved these changes

Assignees
No one assigned
Labels
C-Code-Quality A section of code that is hard to understand or change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mockersf @cart @jakobhellermann