Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - load names of lights from gltf #3553

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - load names of lights from gltf #3553

wants to merge 1 commit into from

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Jan 5, 2022 •
edited
Loading

Objective

  • Load names of lights from gltf

Solution

  • Load names of lights from gltf

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Jan 5, 2022
@alice-i-cecile alice-i-cecile added A-Assets Load files from disk to use for things like images, models, and sounds A-Rendering Drawing game state to the screen S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Triage This issue needs to be labelled labels Jan 5, 2022
@cart
Copy link
Member

cart commented Jan 5, 2022

bors r+

bors bot pushed a commit that referenced this pull request Jan 5, 2022
@mockersf
load names of lights from gltf (#3553)
a1e3c5c 
# Objective

- Load names of lights from gltf

## Solution

- Load names of lights from gltf


Co-authored-by: François <8672791+mockersf@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Jan 5, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title load names of lights from gltf [Merged by Bors] - load names of lights from gltf Jan 5, 2022
@bors bors bot closed this Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Assets Load files from disk to use for things like images, models, and sounds A-Rendering Drawing game state to the screen S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mockersf @cart @alice-i-cecile