Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added custom node rendering example #3650

Closed
wants to merge 4 commits into from

Conversation

Lindenk
Copy link
Contributor

@Lindenk Lindenk commented Jan 12, 2022

Objective

Provide the fruits of my keyboard mashing as an accessible example for creating a custom rendering node.

Solution

Provides a well commented and (hopefully) idiomatic example for creating a rendering node and adding it to a node graph.

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Jan 12, 2022
@DJMcNab
Copy link
Member

DJMcNab commented Jan 12, 2022

I think it would be useful to have a screenshot/video of what this example produces here.

@NiklasEi NiklasEi added A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples and removed S-Needs-Triage This issue needs to be labelled labels Jan 12, 2022
@Lindenk
Copy link
Contributor Author

Lindenk commented Jan 12, 2022

Here you are. I went with something that uses the resolution from ExtractedView, a simple implementation for extracting Time, and the color is extracted from a custom node attached to the camera. I feel like that should provide decent coverage for what a user might want to do
custom_node

@Lindenk
Copy link
Contributor Author

Lindenk commented Jan 12, 2022

I'm also a little unsure how to fix the check_bans check. It seems to pass on my end

Copy link
Contributor

@djeedai djeedai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My 2c is that it's a unique occasion to explain what a render world is, the extraction process, etc. All these things that should be documented but are not. Instead, I don't really see the difference between this example and reading the internal code for e.g. sprite or UI rendering. So I'd suggest to add a lot more comment not only on what is going on but first and foremost why, and how the general process of adding a render node works.

@Nilirad
Copy link
Contributor

Nilirad commented May 3, 2022

This PR adds a new example. Adding module and item level doc comments, as described in:

would be really useful to those who will browse examples.

@IceSentry
Copy link
Contributor

IceSentry commented Oct 1, 2023

Most of this is now covered by the post_processing example.

A more targeted example like this might still be useful but this PR is now very outdated to the point I believe it should just be started from scratch.

@IceSentry IceSentry closed this Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants