-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added custom node rendering example #3650
Conversation
I think it would be useful to have a screenshot/video of what this example produces here. |
I'm also a little unsure how to fix the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My 2c is that it's a unique occasion to explain what a render world is, the extraction process, etc. All these things that should be documented but are not. Instead, I don't really see the difference between this example and reading the internal code for e.g. sprite or UI rendering. So I'd suggest to add a lot more comment not only on what is going on but first and foremost why, and how the general process of adding a render node works.
This PR adds a new example. Adding module and item level doc comments, as described in:
would be really useful to those who will browse examples. |
Most of this is now covered by the A more targeted example like this might still be useful but this PR is now very outdated to the point I believe it should just be started from scratch. |
Objective
Provide the fruits of my keyboard mashing as an accessible example for creating a custom rendering node.
Solution
Provides a well commented and (hopefully) idiomatic example for creating a rendering node and adding it to a node graph.