[Merged by Bors] - Decouple some dependencies #3886
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheRawMeatball
added
A-Build-System
|
I'm unsure about:
I agree with all other changes. I am particularly happy with the changes to |
alice-i-cecile
added
C-Code-Quality
|
bors try |
tryBuild failed: |
|
I dropped "Remove the thiserror usage in bevy_reflect", enabled the full syn feature for bevy_reflect_derive too (which should fix CI) and removed another unused dependency. |
alice-i-cecile
approved these changes
Feb 8, 2022
|
I would prefer to have less different crates depending on |
bors bot
pushed a commit
that referenced
this pull request
Apr 20, 2022
This a commit I think would be uncontroversial that has been cherry-picked from #3886
bors bot
pushed a commit
that referenced
this pull request
Apr 25, 2022
A couple more uncontroversial changes extracted from #3886. * Enable full feature of syn It is necessary for the ItemFn and ItemTrait type. Currently it is indirectly enabled through the tracing dependency of bevy_utils, but this may no longer be the case in the future. * Remove unused function from bevy_macro_utils
bjorn3
force-pushed
the
decouple_deps
branch
2 times, most recently
from
aee38c6
to
9e3b42c
Compare
|
I dropped the uuid change. This reduces the savings for |
mockersf
approved these changes
Apr 27, 2022
mockersf
added
the
S-Ready-For-Final-Review
alice-i-cecile
approved these changes
Apr 27, 2022
|
bors r+ |
|
Merge conflict. |
This allows tracing to be built long before syn is built, which allows for more build parallelism.
Instead add an inherent implementation. This allows removing the bevy_derive dependency from bevy_utils.
This removes a critical path when building
|
Rebased |
|
bors retry |
bors bot
pushed a commit
that referenced
this pull request
Apr 27, 2022
# Objective Reduce from scratch build time. ## Solution Reduce the size of the critical path by removing dependencies between crates where not necessary. For `cargo check --no-default-features` this reduced build time from ~51s to ~45s. For some commits I am not completely sure if the tradeoff between build time reduction and convenience caused by the commit is acceptable. If not, I can drop them.
bors
bot
changed the title
exjam
pushed a commit
to exjam/bevy
that referenced
this pull request
May 22, 2022
This a commit I think would be uncontroversial that has been cherry-picked from bevyengine#3886
exjam
pushed a commit
to exjam/bevy
that referenced
this pull request
May 22, 2022
A couple more uncontroversial changes extracted from bevyengine#3886. * Enable full feature of syn It is necessary for the ItemFn and ItemTrait type. Currently it is indirectly enabled through the tracing dependency of bevy_utils, but this may no longer be the case in the future. * Remove unused function from bevy_macro_utils
exjam
pushed a commit
to exjam/bevy
that referenced
this pull request
May 22, 2022
# Objective Reduce from scratch build time. ## Solution Reduce the size of the critical path by removing dependencies between crates where not necessary. For `cargo check --no-default-features` this reduced build time from ~51s to ~45s. For some commits I am not completely sure if the tradeoff between build time reduction and convenience caused by the commit is acceptable. If not, I can drop them.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
This a commit I think would be uncontroversial that has been cherry-picked from bevyengine#3886
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
A couple more uncontroversial changes extracted from bevyengine#3886. * Enable full feature of syn It is necessary for the ItemFn and ItemTrait type. Currently it is indirectly enabled through the tracing dependency of bevy_utils, but this may no longer be the case in the future. * Remove unused function from bevy_macro_utils
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective Reduce from scratch build time. ## Solution Reduce the size of the critical path by removing dependencies between crates where not necessary. For `cargo check --no-default-features` this reduced build time from ~51s to ~45s. For some commits I am not completely sure if the tradeoff between build time reduction and convenience caused by the commit is acceptable. If not, I can drop them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Reduce from scratch build time.
Solution
Reduce the size of the critical path by removing dependencies between crates where not necessary. For
cargo check --no-default-featuresthis reduced build time from ~51s to ~45s. For some commits I am not completely sure if the tradeoff between build time reduction and convenience caused by the commit is acceptable. If not, I can drop them.