Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Some small changes related to run criteria piping #3923

Closed
wants to merge 3 commits into from

Conversation

DJMcNab
Copy link
Member

@DJMcNab DJMcNab commented Feb 12, 2022

Remove the 'chaining' api, as it's peculiar

Implement the label traits for Box<dyn ThatTrait> (n.b. I'm not confident about this change, but it was the quickest path to not regressing)

Remove the need for '.system' when using run criteria piping

Remove the 'chaining' api, as it's peculiar

Implement the label traits for Box<dyn It>
(n.b., I'm not confident about this change, but it was
the quickest path to not regressing)

Remove the need for '`.system`' within that
@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Feb 12, 2022
@DJMcNab DJMcNab added A-ECS Entities, components, systems, and events M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide C-Code-Quality A section of code that is hard to understand or change and removed S-Needs-Triage This issue needs to be labelled labels Feb 12, 2022
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 12, 2022
@DJMcNab DJMcNab added this to the Bevy 0.7 milestone Feb 24, 2022
@cart
Copy link
Member

cart commented Apr 7, 2022

bors r+

bors bot pushed a commit that referenced this pull request Apr 7, 2022
Remove the 'chaining' api, as it's peculiar

~~Implement the label traits for `Box<dyn ThatTrait>` (n.b. I'm not confident about this change, but it was the quickest path to not regressing)~~

Remove the need for '`.system`' when using run criteria piping
@bors bors bot changed the title Some small changes related to run criteria piping [Merged by Bors] - Some small changes related to run criteria piping Apr 7, 2022
@bors bors bot closed this Apr 7, 2022
@DJMcNab DJMcNab deleted the pipe-yeet branch April 7, 2022 19:51
aevyrie pushed a commit to aevyrie/bevy that referenced this pull request Jun 7, 2022
Remove the 'chaining' api, as it's peculiar

~~Implement the label traits for `Box<dyn ThatTrait>` (n.b. I'm not confident about this change, but it was the quickest path to not regressing)~~

Remove the need for '`.system`' when using run criteria piping
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
Remove the 'chaining' api, as it's peculiar

~~Implement the label traits for `Box<dyn ThatTrait>` (n.b. I'm not confident about this change, but it was the quickest path to not regressing)~~

Remove the need for '`.system`' when using run criteria piping
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants