Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Add clear_schedule #3941

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Add clear_schedule #3941

wants to merge 1 commit into from

Conversation

hlb8122
Copy link
Contributor

@hlb8122 hlb8122 commented Feb 14, 2022 •
edited
Loading

Objective

Adds clear_schedule method to State.

Closes #3932

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Feb 14, 2022
@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use and removed S-Needs-Triage This issue needs to be labelled labels Feb 14, 2022
alice-i-cecile
alice-i-cecile approved these changes Feb 14, 2022
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct and occasionally useful in a way that's very challenging to work-around. I'm not sure that we should keep the state stack, but while it exists, this method should be added.

@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 19, 2022
@mockersf
Copy link
Member

mockersf commented Mar 5, 2022

bors r+

1 similar comment
@mockersf
Copy link
Member

mockersf commented Mar 5, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 5, 2022

Already running a review

bors bot pushed a commit that referenced this pull request Mar 5, 2022
@hlbarber
Add clear_schedule (#3941)
ccb1788 
# Objective

Adds `clear_schedule` method to `State`.

Closes #3932
@bors
Copy link
Contributor

bors bot commented Mar 5, 2022

Build failed:

@mockersf
Copy link
Member

mockersf commented Mar 5, 2022

bors r+

bors bot pushed a commit that referenced this pull request Mar 5, 2022
@hlbarber
Add clear_schedule (#3941)
cf46baa 
# Objective

Adds `clear_schedule` method to `State`.

Closes #3932
@bors
Copy link
Contributor

bors bot commented Mar 5, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Add clear_schedule [Merged by Bors] - Add clear_schedule Mar 5, 2022
@bors bors bot closed this Mar 5, 2022
kurtkuehnert pushed a commit to kurtkuehnert/bevy that referenced this pull request Mar 6, 2022
@hlbarber
Add clear_schedule (bevyengine#3941)
d5e6914 
# Objective

Adds `clear_schedule` method to `State`.

Closes bevyengine#3932
@hlb8122 hlb8122 deleted the add-clear-schedule branch March 8, 2022 01:16
aevyrie pushed a commit to aevyrie/bevy that referenced this pull request Jun 7, 2022
@hlbarber @aevyrie
Add clear_schedule (bevyengine#3941)
664c415 
# Objective

Adds `clear_schedule` method to `State`.

Closes bevyengine#3932
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add clear_schedule method to State
4 participants
@hlb8122 @mockersf @alice-i-cecile @hlbarber