Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow UIPlugin to be used without rendering #4000

Closed
wants to merge 26 commits into from

Conversation

kirusfg
Copy link
Contributor

@kirusfg kirusfg commented Feb 20, 2022

Objective

Solution

  • Make UIPlugin add rendering-dependent systems only when RenderPlugin is enabled

Dependencies

Notes

As stated by cart on Discord regarding #3835:

Lets wait. I'm hesitant to decouple windows from "actual windows" conceptually. If the goal is to test UI, I think we should consider other options (such as render targets or "null" targets). We'll need to decouple UI from windows anyway because we want to enable rendering ui to textures.

this PR might become obsolete as Bevy's UI in general needs an engineering overhaul.

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Feb 20, 2022
Achieved by making loading of some functions conditional: if
RenderPlugin is absent, they are not added.
@kirusfg kirusfg force-pushed the fix/uiplugin-headless branch from 86bb9d4 to 03f63a6 Compare February 20, 2022 16:53
@james7132 james7132 added A-Rendering Drawing game state to the screen A-UI Graphical user interfaces, styles, layouts, and widgets labels Feb 21, 2022
@james7132 james7132 removed the S-Needs-Triage This issue needs to be labelled label Feb 21, 2022
@NthTensor
Copy link
Contributor

@alice-i-cecile @JMS55 @superdump I propose we close this and convert it into an issue, as recommended in the Triage Doc. It's a good idea, but it's stale.

@alice-i-cecile
Copy link
Member

Agreed. Feel free to close this once an issue is up.

@NthTensor
Copy link
Contributor

Oop, looks like the old issue still covers it. Closing

@NthTensor NthTensor closed this Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen A-UI Graphical user interfaces, styles, layouts, and widgets
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

UiPlugin cannot be used without rendering
6 participants