Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Expose draw indirect #4056

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - Expose draw indirect #4056

wants to merge 3 commits into from

Conversation

kurtkuehnert
Copy link
Contributor

Objective

  • Currently there is now way of making an indirect draw call from a tracked render pass.
  • This is a very useful feature for GPU based rendering.

Solution

  • Expose the draw_indirect and draw_indexed_indirect methods from the wgpu RenderPass in the TrackedRenderPass.

Alternative

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Feb 27, 2022
@superdump superdump added A-Rendering Drawing game state to the screen C-Feature A new feature, making something new possible C-Performance A change motivated by improving speed, memory usage or compile times C-Usability A targeted quality-of-life change that makes Bevy easier to use and removed S-Needs-Triage This issue needs to be labelled labels Feb 27, 2022
superdump
superdump reviewed Feb 27, 2022
View reviewed changes
Copy link
Contributor

@superdump superdump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me though I’d need to double-check that the documentation is correct.

@kurtkuehnert
Copy link
Contributor Author

The documentation is copied over from the wgpu equivalent.

@cart
Copy link
Member

cart commented Feb 27, 2022

bors r+

bors bot pushed a commit that referenced this pull request Feb 27, 2022
@kurtkuehnert
Expose draw indirect (#4056)
e15e405 
# Objective

- Currently there is now way of making an indirect draw call from a tracked render pass.
- This is a very useful feature for GPU based rendering.

## Solution

- Expose the `draw_indirect` and `draw_indexed_indirect` methods from the wgpu `RenderPass` in the `TrackedRenderPass`.

## Alternative

- #3595: Expose the underlying `RenderPass` directly
@bors
Copy link
Contributor

bors bot commented Feb 27, 2022

Build failed:

@superdump
Copy link
Contributor

bors r+

I meant to respond "approved but fix the CI errors first" :)

superdump
superdump requested changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@superdump superdump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions that should fix the CI errors.

crates/bevy_render/src/render_phase/draw_state.rs Outdated Show resolved Hide resolved
crates/bevy_render/src/render_phase/draw_state.rs Outdated Show resolved Hide resolved
@kurtkuehnert
Copy link
Contributor Author

Sorry my bad, was in a hurry yesterday.

@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 28, 2022
@mockersf
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Feb 28, 2022
@kurtkuehnert
Expose draw indirect (#4056)
40b3692 
# Objective

- Currently there is now way of making an indirect draw call from a tracked render pass.
- This is a very useful feature for GPU based rendering.

## Solution

- Expose the `draw_indirect` and `draw_indexed_indirect` methods from the wgpu `RenderPass` in the `TrackedRenderPass`.

## Alternative

- #3595: Expose the underlying `RenderPass` directly
@bors
Copy link
Contributor

bors bot commented Feb 28, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Expose draw indirect [Merged by Bors] - Expose draw indirect Feb 28, 2022
@bors bors bot closed this Feb 28, 2022
kurtkuehnert added a commit to kurtkuehnert/bevy that referenced this pull request Mar 6, 2022
@kurtkuehnert
Expose draw indirect (bevyengine#4056)
49a17c7 
# Objective

- Currently there is now way of making an indirect draw call from a tracked render pass.
- This is a very useful feature for GPU based rendering.

## Solution

- Expose the `draw_indirect` and `draw_indexed_indirect` methods from the wgpu `RenderPass` in the `TrackedRenderPass`.

## Alternative

- bevyengine#3595: Expose the underlying `RenderPass` directly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superdump superdump superdump requested changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Feature A new feature, making something new possible C-Performance A change motivated by improving speed, memory usage or compile times C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kurtkuehnert @cart @superdump @mockersf