-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - WorldQuery derive macro now respects visibility #4125
Conversation
Additional NotesGiven this derive macro generates additional structs, there isn't a way currently to annotate those structs with additional attributes like documentation comments. This leaves me with warnings from |
IMO yes, along with a link to [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code checks out. Nice small fix.
Yeah, these structs are implementation details. They should be #4100 proposes to use an anonymous scope for them; however that could be problematic for |
Apologies for the delay, I've added |
I believe the Item struct should not be hidden, as it is the user-facing type. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me, but I'm not super familiar with that code
I agree with this. Someone trying to specify the returned type from a query in code should be able to find it in the docs. |
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
bors r+ |
## Objective Fixes #4122. ## Solution Inherit the visibility of the struct being derived for the `xxItem`, `xxFetch`, `xxState` structs. Co-authored-by: Carter Anderson <mcanders1@gmail.com>
## Objective Fixes bevyengine#4122. ## Solution Inherit the visibility of the struct being derived for the `xxItem`, `xxFetch`, `xxState` structs. Co-authored-by: Carter Anderson <mcanders1@gmail.com>
Objective
Fixes #4122.
Solution
Inherit the visibility of the struct being derived for the
xxItem
,xxFetch
,xxState
structs.