Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed android instant crash #4139

Closed
wants to merge 6 commits into from

Conversation

ManevilleF
Copy link
Contributor

Objective

  • Running any bevy app on android panics immediately

Solution

I don't really understand the changes of this MR, but I know it works.

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Mar 7, 2022
@alice-i-cecile alice-i-cecile added P-Crash A sudden unexpected crash O-Android Specific to the Android mobile operating system P-High This is particularly urgent, and deserves immediate attention and removed S-Needs-Triage This issue needs to be labelled labels Mar 7, 2022
@alice-i-cecile
Copy link
Member

bors try

@bors
Copy link
Contributor

bors bot commented Mar 8, 2022

try

Merge conflict.

@ManevilleF
Copy link
Contributor Author

@alice-i-cecile conflicts occured with #3974 but I rebased on main and fixed the conflicts


let adapter_info = adapter.get_info();
info!("{:?}", adapter_info);
for (i, adapter) in adapters.iter().enumerate() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not convinced this is the right move. I just replied in the original thread here: https://github.com/bevyengine/bevy/pull/3639/files#r828534181

@alice-i-cecile alice-i-cecile added the X-Controversial There is active debate or serious implications around merging this PR label Apr 22, 2022
@ManevilleF ManevilleF closed this Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-Android Specific to the Android mobile operating system P-Crash A sudden unexpected crash P-High This is particularly urgent, and deserves immediate attention X-Controversial There is active debate or serious implications around merging this PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants