Fixed android instant crash #4139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
P-Crash
ManevilleF
force-pushed
the
feat/android_fix
branch
from
7270ab7 to
a3fa374
Compare
|
bors try |
tryMerge conflict. |
ManevilleF
force-pushed
the
feat/android_fix
branch
from
a3fa374 to
8aa9c82
Compare
|
@alice-i-cecile conflicts occured with #3974 but I rebased on main and fixed the conflicts |
cart
reviewed
Mar 16, 2022
|
|
||
| let adapter_info = adapter.get_info(); | ||
| info!("{:?}", adapter_info); | ||
| for (i, adapter) in adapters.iter().enumerate() { |
There was a problem hiding this comment.
I'm not convinced this is the right move. I just replied in the original thread here: https://github.com/bevyengine/bevy/pull/3639/files#r828534181
alice-i-cecile
added
the
X-Controversial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
cargo-apkmetadata the same way as [Merged by Bors] - Fixed Android example icon #4076, which becomes obsolete if this PR gets mergedI don't really understand the changes of this MR, but I know it works.