Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Make RenderStage::Extract run on the render world #4402

Closed
wants to merge 18 commits into from
Closed

[Merged by Bors] - Make RenderStage::Extract run on the render world #4402

wants to merge 18 commits into from

Commits on Jun 24, 2022

  1. Setup infrastructure for render app owns extract

    @DJMcNab
    DJMcNab committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    fbb794d View commit details
    Browse the repository at this point in the history

  2. Finish API 

    Cleverly avoid needing the param to be 'static

This same trick can't work for `StaticSystemParam` fwiw
This is because `StaticSystemParam`'s item needs to exactly
reference the original param, whereas this just stores it
    @DJMcNab
    DJMcNab committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    36e9b12 View commit details
    Browse the repository at this point in the history

  3. Remove spawn_and_forget 

    It's unused, and was only ever needed for the weird extract logic

Remove the trick because it's actually stupid
    @DJMcNab
    DJMcNab committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    80babbf View commit details
    Browse the repository at this point in the history

  4. Add some docs

    @DJMcNab
    DJMcNab committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    90659d4 View commit details
    Browse the repository at this point in the history

  5. Apply buffers after 'extracting' the world 

    See bevyengine#5082
    @DJMcNab
    DJMcNab committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    bcf51e6 View commit details
    Browse the repository at this point in the history

  6. Fix existing references to ExtractFromMainWorld

    @DJMcNab
    DJMcNab committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    8a350d2 View commit details
    Browse the repository at this point in the history

  7. Add reporting of incorrect extract systems

    @DJMcNab
    DJMcNab committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    6204950 View commit details
    Browse the repository at this point in the history

  8. Fix extractions which weren't compiling

    @DJMcNab
    DJMcNab committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    0a12e28 View commit details
    Browse the repository at this point in the history

  9. Oops, all println

    @DJMcNab
    DJMcNab committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    da2dc9f View commit details
    Browse the repository at this point in the history

  10. Migrate all extractions to new method

    @DJMcNab
    DJMcNab committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    ef45123 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2022

  1. Enable "direct" Extract access

    @cart
    cart committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    944aa6d View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into pr/DJMcNab/4402

    @cart
    cart committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    31db748 View commit details
    Browse the repository at this point in the history

  3. clippy

    @cart
    cart committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    ad0ad11 View commit details
    Browse the repository at this point in the history

  4. address my comments

    @cart
    cart committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    12b17bc View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2022

  1. Update crates/bevy_render/src/lib.rs 

    Co-authored-by: Daniel McNab <36049421+DJMcNab@users.noreply.github.com>
    @cart @DJMcNab
    cart and DJMcNab authored Jul 8, 2022
    Configuration menu
    Copy the full SHA
    008d7fe View commit details
    Browse the repository at this point in the history

  2. Resolve comments

    @cart
    cart committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    5563e49 View commit details
    Browse the repository at this point in the history

  3. remove unnecessary clone_weak

    @cart
    cart committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    88df055 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/main' into pr/DJMcNab/4402-1

    @cart
    cart committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    c40e3c1 View commit details
    Browse the repository at this point in the history