[Merged by Bors] - run examples on windows #4437
Conversation
.github/workflows/ci.yml
Outdated
| - uses: actions/checkout@v3 | ||
| - uses: actions/cache@v3 |
There was a problem hiding this comment.
Is there a reason for not using cache on windows?
There was a problem hiding this comment.
mostly because I have no ideas how folders are organised on windows
There was a problem hiding this comment.
I don't know if it's the case in the context of github runners, but as far as I know the paths in the linux run should be the same on windows. There's a ~ alias and windows supporst / so I think using the same paths should work.
IceSentry
added
the
A-Build-System
alice-i-cecile
added
the
P-Critical
|
Added the |
alice-i-cecile
removed
the
P-Critical
|
CI is mysteriously unbroken again, see #4420. I still think we should consider making these changes, in order to reduce the possible points of failure. |
|
I changed the PR to run examples on windows on a daily cron. It's still interesting to have the result, but not worth it to run it on every commit (and that way it'll be easy to copy/paste if there's a failure again) |
alice-i-cecile
added
the
S-Ready-For-Final-Review
IMO we should try to run all of the examples daily on all platforms. I don't have a strong preference about whether that's done in this PR or a follow-up. |
|
I suspect the examples should be run on the bors try/staging commits too, even if not run on every commit within a PR? For example, being able to minimise windows on windows is both quite an important property to preserve, and apparently an easy property to lose. Without this test we can't ensure that PR authors maintain this property; only get a failure in the (as far as I know) low-visibility daily run. |
mockersf
force-pushed
the
run-examples-on-windows
branch
from
e6728d0 to
12a925c
Compare
|
windows and iOS won't run on a commit/PR, but will run on a bors command |
|
bors try |
tryBuild failed: |
|
it failed on windows on the minimising example 🎉 |
|
bors r+ |
# Objective - ~~Running examples on Linux in CI timeout~~Linux is back! - But hey we can run examples on windows too! ## Solution - Run examples on windows daily - I also added a 30 minutes timeout so that when it explodes, it doesn't explodes in 6 hours (the default timeout) - And simplified the linux examples by not requiring a custom feature set
|
Build failed: |
|
bors r- |
alice-i-cecile
added
the
S-Blocked
|
blocked on #4527 |
mockersf
force-pushed
the
run-examples-on-windows
branch
from
ccc11b1 to
0223cfc
Compare
alice-i-cecile
added
the
O-Windows
|
bors try |
|
bors r+ |
# Objective - ~~Running examples on Linux in CI timeout~~Linux is back! - But hey we can run examples on windows too! ## Solution - Run examples on windows daily - I also added a 30 minutes timeout so that when it explodes, it doesn't explodes in 6 hours (the default timeout) - And simplified the linux examples by not requiring a custom feature set
bors
bot
changed the title
# Objective - ~~Running examples on Linux in CI timeout~~Linux is back! - But hey we can run examples on windows too! ## Solution - Run examples on windows daily - I also added a 30 minutes timeout so that when it explodes, it doesn't explodes in 6 hours (the default timeout) - And simplified the linux examples by not requiring a custom feature set
# Objective - ~~Running examples on Linux in CI timeout~~Linux is back! - But hey we can run examples on windows too! ## Solution - Run examples on windows daily - I also added a 30 minutes timeout so that when it explodes, it doesn't explodes in 6 hours (the default timeout) - And simplified the linux examples by not requiring a custom feature set
Objective
Running examples on Linux in CI timeoutLinux is back!Solution