Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Remove parking_lot dependency from bevy_ecs #4543

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Remove parking_lot dependency from bevy_ecs #4543

wants to merge 1 commit into from

Conversation

bjorn3
Copy link
Contributor

@bjorn3 bjorn3 commented Apr 20, 2022

It is only used in some tests so any potential performance regressions don't matter.

@bjorn3
Remove parking_lot dependency from bevy_ecs
ee0834a 
It is only used in some tests so any potential performance regressions
don't matter.
@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Apr 20, 2022
@bjorn3 bjorn3 added A-ECS Entities, components, systems, and events C-Dependencies A change to the crates that Bevy depends on C-Code-Quality A section of code that is hard to understand or change and removed S-Needs-Triage This issue needs to be labelled labels Apr 20, 2022
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Apr 20, 2022
@mockersf
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Apr 20, 2022
@bjorn3
Remove parking_lot dependency from bevy_ecs (#4543)
e65f28d 
It is only used in some tests so any potential performance regressions don't matter.
@bors
Copy link
Contributor

bors bot commented Apr 20, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Remove parking_lot dependency from bevy_ecs [Merged by Bors] - Remove parking_lot dependency from bevy_ecs Apr 20, 2022
@bors bors bot closed this Apr 20, 2022
@bjorn3 bjorn3 deleted the no_bevy_ecs_parking_lot branch April 20, 2022 12:47
exjam pushed a commit to exjam/bevy that referenced this pull request May 22, 2022
@bjorn3 @exjam
Remove parking_lot dependency from bevy_ecs (bevyengine#4543)
c1e40b8 
It is only used in some tests so any potential performance regressions don't matter.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@bjorn3 @ItsDoot
Remove parking_lot dependency from bevy_ecs (bevyengine#4543)
b9864f2 
It is only used in some tests so any potential performance regressions don't matter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@mockersf mockersf mockersf approved these changes

@jakobhellermann jakobhellermann jakobhellermann approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change C-Dependencies A change to the crates that Bevy depends on S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bjorn3 @mockersf @alice-i-cecile @jakobhellermann