Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Remove EntityMut::get_unchecked #4547

Closed

Conversation

TheRawMeatball
Copy link
Member

@TheRawMeatball TheRawMeatball commented Apr 20, 2022

The only way to soundly use this API is already encapsulated within EntityMut::get, so this api is removed.

Migration guide

Replace calls to EntityMut::get_unchecked with calls to EntityMut::get.

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Apr 20, 2022
@TheRawMeatball TheRawMeatball added A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change and removed S-Needs-Triage This issue needs to be labelled labels Apr 20, 2022
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Apr 20, 2022
@alice-i-cecile
Copy link
Member

Looks good; we've been over this at length over in #3001.

@alice-i-cecile
Copy link
Member

@TheRawMeatball, can you make a quick migration guide? This is technically a breaking change.

@alice-i-cecile alice-i-cecile added the M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide label Apr 20, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Apr 22, 2022
The only way to soundly use this API is already encapsulated within `EntityMut::get`, so this api is removed.

# Migration guide

Replace calls to `EntityMut::get_unchecked` with calls to `EntityMut::get`.
@bors bors bot changed the title Remove EntityMut::get_unchecked [Merged by Bors] - Remove EntityMut::get_unchecked Apr 22, 2022
@bors bors bot closed this Apr 22, 2022
exjam pushed a commit to exjam/bevy that referenced this pull request May 22, 2022
The only way to soundly use this API is already encapsulated within `EntityMut::get`, so this api is removed.

# Migration guide

Replace calls to `EntityMut::get_unchecked` with calls to `EntityMut::get`.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
The only way to soundly use this API is already encapsulated within `EntityMut::get`, so this api is removed.

# Migration guide

Replace calls to `EntityMut::get_unchecked` with calls to `EntityMut::get`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants