Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Make Transform propagation correct in the presence of updated children #4608

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - Make Transform propagation correct in the presence of updated children #4608

wants to merge 6 commits into from

Commits on Apr 26, 2022

  1. Closes bevyengine#3329 

    `parent_update` and `transform_propagate` run in the same stage but `parent_update` can spawn `Children`. This means that the `system` can enter an inconsistent state where the `GlobalTransform` has not been updated on `Children` when spawning an `Entity` where the `Parent` does not have an existing `Children` component.

Introduce a marker trait, `DirtyParent`, so that the system will revert to the correct state the next time the systems run.
    @yilinwei @DJMcNab
    yilinwei authored and DJMcNab committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    0977aba View commit details
    Browse the repository at this point in the history

  2. Move to updating when Children have changed

    @DJMcNab
    DJMcNab committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    471cc92 View commit details
    Browse the repository at this point in the history

  3. Implement the changes to check if Children changed

    @DJMcNab
    DJMcNab committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    bed4091 View commit details
    Browse the repository at this point in the history

  4. Make the test multi-layered and use App instead

    @DJMcNab
    DJMcNab committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    ef08753 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2022

  1. Make import worse 

    As requsted by @mockersf
    @DJMcNab
    DJMcNab committed May 1, 2022
    Configuration menu
    Copy the full SHA
    a5509de View commit details
    Browse the repository at this point in the history

  2. Only use one Option

    @DJMcNab
    DJMcNab committed May 1, 2022
    Configuration menu
    Copy the full SHA
    9591e78 View commit details
    Browse the repository at this point in the history