[Merged by Bors] - Fix CI

[BoxyUwU]

No description provided.

[mockersf]

is it due to a regression in rust nightly, or is it something that we actually need to fix in Bevy?

[BoxyUwU]

regression but i'd be kind of surprised if it was fixed since it doesnt seem like a clear cut "bug"
..plus I'd like one of my other PRs to get merged and not have to wait ages for if they do fix it

[superdump]

I don't fully understand the nitty gritty details, just the high-level concept that the rust compiler has changed something in nightly that affects the way it is able to prove lifetime constraints for various types/traits that caused this regression, and that this PR changes the lifetime annotations in such a way that the rust compiler can verify their validity. Thanks to @BoxyUwU for taking the time on Discord to discuss with and explain to me what this is about.

I also think it is important to unblock CI. We discussed whether the problem should be fixed upstream (yes?) and whether it's likely to happen soon (no?). We discussed alternatives to unblock CI such as make rust nightly builds failing not block CI (would make rust nightly users sad, and miri jobs identifying undefined behaviour would have to also be made non-blocking, which is also bad) and didn't come up with anything that feels better than merging this PR.

As such, I approve this.

[mockersf]

bors r+

[bors]

Pull request successfully merged into main.

Build succeeded:

• build-android
• build (nightly, ubuntu-latest)
• build (stable, macos-latest)
• build (stable, ubuntu-latest)
• build (stable, windows-latest)
• build-wasm (nightly, ubuntu-latest)
• build-wasm (stable, ubuntu-latest)
• check-compiles
• check-doc
• check-markdown-links
• check-missing-examples-in-docs
• check-unused-dependencies
• ci
• markdownlint
• miri
• run-examples

[mockersf]

Discussion about this in the rust-lang repo: rust-lang/rust#89352 (comment)
For now, waiting for a crater run to see the impact